-
Notifications
You must be signed in to change notification settings - Fork 15
Refactor Deposit and Withdraw Modals to Support Network Selection #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicktytarenko
wants to merge
14
commits into
main
Choose a base branch
from
rsc-withdrawal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Enhance User Experience - Introduced a NetworkSelector component for selecting between BASE and ETHEREUM networks in both DepositModal and WithdrawModal. - Updated transaction fee fetching to be network-specific. - Enhanced user feedback with success and error messages in WithdrawalSuccessView. - Improved modal structure by replacing Dialog components with BaseModal for consistency. - Added loading states and error handling for wallet balance and transaction processes. - Refactored input handling and validation for deposit and withdrawal amounts.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
addressing comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Overview
This PR introduces multi-network support for ResearchCoin (RSC) deposits and withdrawals, allowing users to interact with both Base and Ethereum networks.